-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Upgrade svelvet #358
Conversation
examples/websocket-relay/relay-app/src/components/WorkflowDetail.svelte
Outdated
Show resolved
Hide resolved
examples/websocket-relay/relay-app/src/components/controls/TaskValue.svelte
Outdated
Show resolved
Hide resolved
examples/websocket-relay/relay-app/src/components/WorkflowDetail.svelte
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #358 +/- ##
==========================================
- Coverage 72.83% 72.18% -0.66%
==========================================
Files 69 69
Lines 6848 6848
==========================================
- Hits 4988 4943 -45
- Misses 1860 1905 +45 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for taking this one on. 🙏
No worries! Sorry it took about three days longer than I'd expected 😅 on the bright side, I'm feeling much more knowledgable about both homestar and svelvet now 👍🏼 |
Description
svelvet
to v8(using newAnchor
,Edge
andNode
components)Link to issue
#337
Type of change
Test plan (required)
cargo run -- start -c config/settings.toml
fromhomestar/examples/websocket-relay
npm run dev
fromhomestar/examples/websocket-relay/relay-app
Screenshots/Screencaps
https://www.loom.com/share/acc35d252e8b4d5a94a6f0d53aecfa91?sid=54cdb36b-1837-4082-b759-f8e80f36503e